[webkit-reviews] review granted: [Bug 233143] [JSC] Shadow realms: set correct Function prototype on wrapped functions : [Attachment 444710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 13:48:04 PST 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Joseph Griego
<jgriego at igalia.com>'s request for review:
Bug 233143: [JSC] Shadow realms: set correct Function prototype on wrapped
functions
https://bugs.webkit.org/show_bug.cgi?id=233143

Attachment 444710: Patch

https://bugs.webkit.org/attachment.cgi?id=444710&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 444710
  --> https://bugs.webkit.org/attachment.cgi?id=444710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444710&action=review

r=me but probably, eventually, I think we need to use bound function.

> Source/JavaScriptCore/builtins/ShadowRealmPrototype.js:56
> +	   if (callerRealm !== null) {
> +	       @moveFunctionToRealm(wrapped, callerRealm);
> +	   }

WebKit coding style do not use brace if there is only one statement.


More information about the webkit-reviews mailing list