[webkit-reviews] review granted: [Bug 233275] [JSC] Add branchTest16 operation : [Attachment 444614] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 18 11:56:06 PST 2021
Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 233275: [JSC] Add branchTest16 operation
https://bugs.webkit.org/show_bug.cgi?id=233275
Attachment 444614: Patch
https://bugs.webkit.org/attachment.cgi?id=444614&action=review
--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 444614
--> https://bugs.webkit.org/attachment.cgi?id=444614
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444614&action=review
r=me with comments.
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1800
> + // use addressTempRegister incase the branchTest16 we call uses
dataTempRegister. :-/
/incase/in case/ and /branchTest16/branchTest32/
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1808
> + // use addressTempRegister incase the branchTest16 we call uses
dataTempRegister. :-/
Ditto
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1816
> + // use addressTempRegister incase the branchTest16 we call uses
dataTempRegister. :-/
Ditto
> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2102
> + MacroAssemblerHelpers::load16OnCondition(*this, cond, address,
dataTempRegister);
> + return branchTest32(cond, dataTempRegister, mask16);
Should these be using addrTempRegister also? Ditto below.
More information about the webkit-reviews
mailing list