[webkit-reviews] review granted: [Bug 232707] [GTK][a11y] Add implementation of hyperlink interface when building with ATSPI : [Attachment 444662] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 232707: [GTK][a11y] Add implementation of hyperlink interface when building
with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=232707

Attachment 444662: Patch

https://bugs.webkit.org/attachment.cgi?id=444662&action=review




--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 444662
  --> https://bugs.webkit.org/attachment.cgi?id=444662
Patch

Patch LGTM with a nit. Please apply the suggestion below before landing :)

View in context: https://bugs.webkit.org/attachment.cgi?id=444662&action=review

> Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:499
> +	   if (--index == -1)

This modifies “index“ in place, which made me wonder “why, and where is the
modified
value used later?“. But then it's not used again at all. So I would prefer to
have
this check written this way for readability:

  if (index == 0)

=)