[webkit-reviews] review granted: [Bug 233241] Convert error to string before passing to testFailed() in FileSystemAccess layout tests : [Attachment 444483] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 233241: Convert error to string before passing to testFailed() in
FileSystemAccess layout tests
https://bugs.webkit.org/show_bug.cgi?id=233241

Attachment 444483: Patch

https://bugs.webkit.org/attachment.cgi?id=444483&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 444483
  --> https://bugs.webkit.org/attachment.cgi?id=444483
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444483&action=review

> LayoutTests/ChangeLog:8
> +	   testFailed() in js-test.js expects string, but finishTest() may
receive Error object as parameter.

Proposed approach is fine, but why not updating testFailed to pretty print
Error itself?

> LayoutTests/storage/filesystemaccess/resources/shared.js:8
> +	   }

We usually do not need { } for one liner if.