[webkit-reviews] review requested: [Bug 233088] Add support for onpushsubscriptionchange event handler : [Attachment 444615] Patch

[bugzilla-daemon at webkit.org]

Ben Nham <nham at apple.com> has asked  for review:
Bug 233088: Add support for onpushsubscriptionchange event handler
https://bugs.webkit.org/show_bug.cgi?id=233088

Attachment 444615: Patch

https://bugs.webkit.org/attachment.cgi?id=444615&action=review




--- Comment #12 from Ben Nham <nham at apple.com> ---
Comment on attachment 444615
  --> https://bugs.webkit.org/attachment.cgi?id=444615
Patch

I think I addressed all the feedback. One difference is that I kept two
PushSubscription constructors rather than using a default parameter. This is
mainly because Internals calls the constructor and calling the constructor with
a RefPtr<ServiceWorkerRegistration> parameter would require us to export
ServiceWorkerRegistration due to the way RefPtr works. It seems cleaner to not
export that object purely for testing purposes (although i could do that
instead if you prefer).