[webkit-reviews] review granted: [Bug 230136] Implement 'gamepad' Permissions Policy : [Attachment 444603] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 17:35:03 PST 2021

Darin Adler <darin at apple.com> has granted Marcos Caceres <marcos at marcosc.com>'s
request for review:
Bug 230136: Implement 'gamepad' Permissions Policy

Attachment 444603: Patch


--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 444603
  --> https://bugs.webkit.org/attachment.cgi?id=444603

View in context: https://bugs.webkit.org/attachment.cgi?id=444603&action=review

> Source/WebCore/Modules/gamepad/NavigatorGamepad.h:30
> +#include "ExceptionOr.h"

It’s fine to include ExceptionOr.h and we have been doing that in other
headers. But I’ve been wondering lately if we could get away with forward
declarations instead in a case like this one.

    template<typename> class ExceptionOr;

That typically works for other return values in other similar cases, but for
some reason we haven’t done that for ExecptionOr.

More information about the webkit-reviews mailing list