[webkit-reviews] review granted: [Bug 233291] [css-values-4] Dynamic `*dv*` viewport units should not respect the page scale : [Attachment 444599] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 16:35:14 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 233291: [css-values-4] Dynamic `*dv*` viewport units should not respect the
page scale
https://bugs.webkit.org/show_bug.cgi?id=233291

Attachment 444599: Patch

https://bugs.webkit.org/attachment.cgi?id=444599&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 444599
  --> https://bugs.webkit.org/attachment.cgi?id=444599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444599&action=review

> Source/WebCore/page/FrameView.cpp:5680
> +    return layoutViewportRect().size();

Have you tested the behavior in MobileSafari/SFSafariViewController/Web.app?


More information about the webkit-reviews mailing list