[webkit-reviews] review granted: [Bug 233239] When an "autofilled and viewable" field becomes empty, turn "autofilled and viewable" off : [Attachment 444595] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 233239: When an "autofilled and viewable" field becomes empty, turn
"autofilled and viewable" off
https://bugs.webkit.org/show_bug.cgi?id=233239

Attachment 444595: Patch

https://bugs.webkit.org/attachment.cgi?id=444595&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 444595
  --> https://bugs.webkit.org/attachment.cgi?id=444595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444595&action=review

I did not set commit-queue+ yet since you may want to consider a different
test, which could change the patch further. But you are also welcome to land
this and then refine from here.

> Source/WebCore/testing/Internals.idl:413
> +    undefined setValueFromRenderer(HTMLInputElement inputElement, DOMString
text);

I am really happy we added a test, but this should new function should not have
been required.

We should be able to construct a test that changes the value by selecting the
text and then doing a backspace with eventSender.keyDown('\u0008'), or
something roughly like that, which would do more end-to-end testing and not
require any change to internals.