[webkit-reviews] review granted: [Bug 228615] [JSC/Air] Optimize enableMovesOnValueAndAdjacents in IRC : [Attachment 434580] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 16:14:30 PST 2021


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 228615: [JSC/Air] Optimize enableMovesOnValueAndAdjacents in IRC
https://bugs.webkit.org/show_bug.cgi?id=228615

Attachment 434580: Patch

https://bugs.webkit.org/attachment.cgi?id=434580&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 434580
  --> https://bugs.webkit.org/attachment.cgi?id=434580
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434580&action=review

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1322
> +    // Set of Tmps whose moves are now ready for possible coalescing.
> +    BitVector m_hasMovesToEnable;

nit: I'd name this "m_movesToEnable"


More information about the webkit-reviews mailing list