[webkit-reviews] review granted: [Bug 230065] Web Inspector: Add a swatch for align-content : [Attachment 444580] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 16:04:25 PST 2021


Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 230065: Web Inspector: Add a swatch for align-content
https://bugs.webkit.org/show_bug.cgi?id=230065

Attachment 444580: Patch

https://bugs.webkit.org/attachment.cgi?id=444580&action=review




--- Comment #21 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 444580
  --> https://bugs.webkit.org/attachment.cgi?id=444580
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444580&action=review

r=me, nice work :)

> Source/WebInspectorUI/UserInterface/Views/AlignmentEditor.js:53
> +    static isAlignContentValue(value)

This should be changed to `isAlignmentValue` since
`WI.AlignmentEditor.ValueGlyphs` is not specific to `align-content` anymore.


More information about the webkit-reviews mailing list