[webkit-reviews] review granted: [Bug 233239] When an “autofilled and viewable” field becomes empty, turn “autofilled and viewable” off : [Attachment 444481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 12:34:26 PST 2021

Darin Adler <darin at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 233239: When an “autofilled and viewable” field becomes empty, turn
“autofilled and viewable” off

Attachment 444481: Patch


--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 444481
  --> https://bugs.webkit.org/attachment.cgi?id=444481

View in context: https://bugs.webkit.org/attachment.cgi?id=444481&action=review

We should add a regression test, which is required for bug fixes in WebKit; I
believe we have this wired up so we can make such tests

> Source/WebCore/html/HTMLInputElement.cpp:1165
> +    // Clear AutoFilled and viewable on field becomming empty.

This comment doesn’t fit WebKit’s coding style. Comments should answer the
question "why" rather than just saying the same thing the code does below. The
comment above has a similar problem. Please consider rewording so this does
something other than just saying in English what the code just below it does.

Also, misspelling of the word "becoming".

More information about the webkit-reviews mailing list