[webkit-reviews] review granted: [Bug 233075] Add a helper class to coordinate batch analysis of images : [Attachment 444527] Remove unnecessary SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 11:21:04 PST 2021


Dean Jackson <dino at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 233075: Add a helper class to coordinate batch analysis of images
https://bugs.webkit.org/show_bug.cgi?id=233075

Attachment 444527: Remove unnecessary SPI

https://bugs.webkit.org/attachment.cgi?id=444527&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 444527
  --> https://bugs.webkit.org/attachment.cgi?id=444527
Remove unnecessary SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=444527&action=review

> Source/WebCore/page/ImageAnalysisQueue.cpp:59
> +    auto imageIterator = document.images()->createIterator();

What order does document.images() use? I wonder if we can have an iterator that
is in document order (more likely to have the images on screen up front).

Also, what happens with lazy loaded images?


More information about the webkit-reviews mailing list