[webkit-reviews] review granted: [Bug 231945] MediaPlayerAVFoundation should support rvfc : [Attachment 444492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 10:20:14 PST 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 231945: MediaPlayerAVFoundation should support rvfc
https://bugs.webkit.org/show_bug.cgi?id=231945

Attachment 444492: Patch

https://bugs.webkit.org/attachment.cgi?id=444492&action=review




--- Comment #23 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 444492
  --> https://bugs.webkit.org/attachment.cgi?id=444492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444492&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1468
> +    metadata.presentationTime =
MonotonicTime::now().secondsSinceEpoch().seconds();
> +    metadata.expectedDisplayTime = metadata.presentationTime;

Maybe add a FIXME here as these probably aren't always equivalent


More information about the webkit-reviews mailing list