[webkit-reviews] review granted: [Bug 233253] [GLIB] jsc_value_object_define_property_accessor() throws an exception when called on a value without a wrapper instance : [Attachment 444514] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 233253: [GLIB] jsc_value_object_define_property_accessor() throws an
exception when called on a value without a wrapper instance
https://bugs.webkit.org/show_bug.cgi?id=233253

Attachment 444514: Patch

https://bugs.webkit.org/attachment.cgi?id=444514&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 444514
  --> https://bugs.webkit.org/attachment.cgi?id=444514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444514&action=review

Nice tests.

> Source/JavaScriptCore/ChangeLog:9
> +	   instance. When called with a value ot having an instance we get an
exception because the expected instance is

not