[webkit-reviews] review granted: [Bug 228022] Images as grid items should use the overridingLogicalWidth when defined to compute the logical Height : [Attachment 444373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 02:18:25 PST 2021


Javier Fernandez <jfernandez at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 228022: Images as grid items should use the overridingLogicalWidth when
defined to compute the logical Height
https://bugs.webkit.org/show_bug.cgi?id=228022

Attachment 444373: Patch

https://bugs.webkit.org/attachment.cgi?id=444373&action=review




--- Comment #15 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 444373
  --> https://bugs.webkit.org/attachment.cgi?id=444373
Patch

r=me 

The changes looks good; it seems the only difference with the version we had
landed is that now the caller is the grid item, as it should have been. 

However, I wonder whether we need also the lines removed in the patch to fix
the bug #228325. Perhaps that regression was caused by the error we are fixing
now in this patch, due to calling constrainLogicalWidthInFragmentByMinMax from
the grid container .


More information about the webkit-reviews mailing list