[webkit-reviews] review granted: [Bug 233222] [LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes. : [Attachment 444454] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 16 21:28:43 PST 2021
Antti Koivisto <koivisto at iki.fi> has granted review:
Bug 233222: [LFC][IFC] break-word is not considered when calculating
min-content intrinsic sizes.
https://bugs.webkit.org/show_bug.cgi?id=233222
Attachment 444454: Patch
https://bugs.webkit.org/attachment.cgi?id=444454&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 444454
--> https://bugs.webkit.org/attachment.cgi?id=444454
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444454&action=review
> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:155
> + bool m_isIntrinsicWidthMode { false };
m_isInIntrinsicWidthMode would read better.
Or
enum class WidthMode : bool { Layout, Intrinsic };
WidthMode m_widthMode;
More information about the webkit-reviews
mailing list