[webkit-reviews] review granted: [Bug 183994] border-radius inline style serializes with invalid syntax : [Attachment 444365] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 16 10:58:45 PST 2021
Darin Adler <darin at apple.com> has granted Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 183994: border-radius inline style serializes with invalid syntax
https://bugs.webkit.org/show_bug.cgi?id=183994
Attachment 444365: Patch
https://bugs.webkit.org/attachment.cgi?id=444365&action=review
--- Comment #28 from Darin Adler <darin at apple.com> ---
Comment on attachment 444365
--> https://bugs.webkit.org/attachment.cgi?id=444365
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444365&action=review
A little sad how repetitive this code is. And it’s kind of sad that to build
the single string result we have to allocate 11 strings and destroy 10 of them.
But I think this is done pretty well now and seems ready to land.
> Source/WebCore/css/StyleProperties.cpp:402
> + if (!topLeftValue || !topRightValue || !bottomRightValue ||
!bottomLeftValue)
> + return String();
We’ve already checked !topLeftValue above. No need to check it again here.
More information about the webkit-reviews
mailing list