[webkit-reviews] review granted: [Bug 232716] Implement FileSystemFileHandle.getFile() : [Attachment 444401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 10:56:38 PST 2021


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 232716: Implement FileSystemFileHandle.getFile()
https://bugs.webkit.org/show_bug.cgi?id=232716

Attachment 444401: Patch

https://bugs.webkit.org/attachment.cgi?id=444401&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 444401
  --> https://bugs.webkit.org/attachment.cgi?id=444401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444401&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp:62
> +	   promise.settle(File::create(context, result.returnValue(), { },
protectedThis->name()));

Should be resolve, not settle.

> Source/WebCore/fileapi/Blob.h:86
> +    static Ref<Blob> deserialize(ScriptExecutionContext* context, const URL&
srcURL, const String& type, std::optional<long long> size, const String&
fileBackedPath)

Why is this needed?

> Source/WebCore/platform/network/BlobRegistryImpl.cpp:235
> +	   return nullptr;

Wy is this needed?


More information about the webkit-reviews mailing list