[webkit-reviews] review denied: [Bug 233195] REGRESSION (r283723): Web Inspector: CSS declarations unexpectedly removed when editing property value : [Attachment 444403] WIP

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has denied  review:
Bug 233195: REGRESSION (r283723): Web Inspector: CSS declarations unexpectedly
removed when editing property value
https://bugs.webkit.org/show_bug.cgi?id=233195

Attachment 444403: WIP

https://bugs.webkit.org/attachment.cgi?id=444403&action=review




--- Comment #2 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 444403

  --> https://bugs.webkit.org/attachment.cgi?id=444403&action=review

WIP

The problem is when CSS property name is fully cleared (step 2), CSSProperty
model gets removed from CSSStyleDeclaration#_properties. Consequent changes to
that property don’t get saved. 

The WIP fixes the bug. The fix introduces `_indexBeforeDetached` property,
which I don't like too much. I'm going to explore the alternatives; so far they
are worse than the WIP.