[webkit-reviews] review granted: [Bug 233191] [iOS] Do not require the web browser entitlement to opt into captive portal mode : [Attachment 444385] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 16 08:08:05 PST 2021
Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 233191: [iOS] Do not require the web browser entitlement to opt into
captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=233191
Attachment 444385: Patch
https://bugs.webkit.org/attachment.cgi?id=444385&action=review
--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 444385
--> https://bugs.webkit.org/attachment.cgi?id=444385
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444385&action=review
r=me
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7750
> + [preferences _setCaptivePortalModeEnabled:NO];
Nit: Whitespace is wrong here.
More information about the webkit-reviews
mailing list