[webkit-reviews] review requested: [Bug 233088] Add support for onpushsubscriptionchange event handler : [Attachment 444146] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 15 22:22:18 PST 2021


Ben Nham <nham at apple.com> has asked  for review:
Bug 233088: Add support for onpushsubscriptionchange event handler
https://bugs.webkit.org/show_bug.cgi?id=233088

Attachment 444146: Patch

https://bugs.webkit.org/attachment.cgi?id=444146&action=review




--- Comment #4 from Ben Nham <nham at apple.com> ---
Comment on attachment 444146
  --> https://bugs.webkit.org/attachment.cgi?id=444146
Patch

I can't repro the timeout in the ios-wk2 tests locally. Maybe there's something
inherently flaky in the way I wrote the test that I'm not seeing yet.

I'd still like to get some feedback, so setting the r? flag.


More information about the webkit-reviews mailing list