[webkit-reviews] review granted: [Bug 233044] Add support for injecting and rendering text recognition blocks : [Attachment 444194] Minor adjustments / rebase on trunk

[bugzilla-daemon at webkit.org]

Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 233044: Add support for injecting and rendering text recognition blocks
https://bugs.webkit.org/show_bug.cgi?id=233044

Attachment 444194: Minor adjustments / rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=444194&action=review




--- Comment #3 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 444194
  --> https://bugs.webkit.org/attachment.cgi?id=444194
Minor adjustments / rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=444194&action=review

r=me

> Source/WebCore/dom/ImageOverlay.cpp:501
> +    for (size_t index = 0; index < result.blocks.size(); ++index) {

Should we add an assertion that `result.blocks.size() ==
elements.blocks.size()`?

> Source/WebCore/dom/ImageOverlay.cpp:502
> +	   auto blockContainer = elements.blocks[index];

Nit: I would move this declaration after the `continue`, since it's not used
otherwise.