[webkit-reviews] review granted: [Bug 233015] [Cocoa] Web Inspector: fix bundle identifier lookup for enabling remote inspection : [Attachment 444296] Patch v1.2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted BJ Burg <bburg at apple.com>'s request
for review:
Bug 233015: [Cocoa] Web Inspector: fix bundle identifier lookup for enabling
remote inspection
https://bugs.webkit.org/show_bug.cgi?id=233015

Attachment 444296: Patch v1.2

https://bugs.webkit.org/attachment.cgi?id=444296&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 444296
  --> https://bugs.webkit.org/attachment.cgi?id=444296
Patch v1.2

View in context: https://bugs.webkit.org/attachment.cgi?id=444296&action=review

> Source/WebKit/UIProcess/Cocoa/WebInspectorPreferenceObserver.mm:53
> +    String sandboxBrokerBundleIdentifier =
WebKit::bundleIdentifierForSandboxBroker();

I suggest not involving WTF::String at all:

    auto sandboxBrokerBundleIdentifier =
WebKit::bundleIdentifierForSandboxBroker();
    m_userDefaults = adoptNS([[NSUserDefaults alloc]
initWithSuiteName:bridge_cast(sandboxBrokerBundleIdentifier)]);
    if (!m_userDefaults) {
	WTFLogAlways("Could not init user defaults instance for domain %@.",
sandboxBrokerBundleIdentifier);