[webkit-reviews] review granted: [Bug 233026] Web Inspector: Layers Tab: the position of composited layer with box-shadow is wrong : [Attachment 444184] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 15 12:51:53 PST 2021
Devin Rousso <drousso at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 233026: Web Inspector: Layers Tab: the position of composited layer with
box-shadow is wrong
https://bugs.webkit.org/show_bug.cgi?id=233026
Attachment 444184: Patch
https://bugs.webkit.org/attachment.cgi?id=444184&action=review
--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 444184
--> https://bugs.webkit.org/attachment.cgi?id=444184
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444184&action=review
r=me, nice!
> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:296
> + new THREE.Vector3(x, -y-height, 0),
> + new THREE.Vector3(x+width, -y-height, 0),
> + new THREE.Vector3(x+width, -y, 0),
Style: please add spaces between operators
```
new THREE.Vector3(x, -y - height, 0),
new THREE.Vector3(x + width, -y - height, 0),
new THREE.Vector3(x + width, -y, 0),
```
More information about the webkit-reviews
mailing list