[webkit-reviews] review granted: [Bug 233114] Fingers down on the trackpad should stop an animated scroll : [Attachment 444202] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 14 18:44:38 PST 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 233114: Fingers down on the trackpad should stop an animated scroll
https://bugs.webkit.org/show_bug.cgi?id=233114

Attachment 444202: Patch

https://bugs.webkit.org/attachment.cgi?id=444202&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 444202
  --> https://bugs.webkit.org/attachment.cgi?id=444202
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444202&action=review

> Source/WebCore/platform/mac/ScrollingEffectsController.mm:143
> +	   return true;

Is returning `true` correct for the `PlatformWheelEventPhase::Cancelled` case
as well?


More information about the webkit-reviews mailing list