[webkit-reviews] review granted: [Bug 233094] [libpas] update to 48d608bf31ba92f8059d2c76488f00c52aaca15a: changes to support universal isoheaps : [Attachment 444161] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 14 01:55:42 PST 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 233094: [libpas] update to 48d608bf31ba92f8059d2c76488f00c52aaca15a:
changes to support universal isoheaps
https://bugs.webkit.org/show_bug.cgi?id=233094

Attachment 444161: the patch

https://bugs.webkit.org/attachment.cgi?id=444161&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 444161
  --> https://bugs.webkit.org/attachment.cgi?id=444161
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444161&action=review

r=me

> Source/bmalloc/libpas/README:1
> +# libpas - Phil's Awesome System

NICE

> Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c:535
> +    static const bool verbose = false;

Maybe we do not need `static` here.


More information about the webkit-reviews mailing list