[webkit-reviews] review granted: [Bug 233090] Implement UIScriptController.sendEventStream() for DumpRenderTree : [Attachment 444147] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 233090: Implement UIScriptController.sendEventStream() for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=233090

Attachment 444147: Patch

https://bugs.webkit.org/attachment.cgi?id=444147&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 444147
  --> https://bugs.webkit.org/attachment.cgi?id=444147
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444147&action=review

r=mews

> Tools/DumpRenderTree/mac/EventSendingController.mm:888
> +    // Note that the delta get convered to integral values here. NSEvent has
float deltas, CGEvent has integral deltas.

sp. - "convered"

> Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:178
> +static NSString* const TopLevelEventInfoKey = @"events";

Nit - * on the wrong side for these constants.