[webkit-reviews] review granted: [Bug 233062] webView._isBeingInspected does not work with Service Worker pages : [Attachment 444096] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 233062: webView._isBeingInspected does not work with Service Worker pages
https://bugs.webkit.org/show_bug.cgi?id=233062

Attachment 444096: Patch

https://bugs.webkit.org/attachment.cgi?id=444096&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 444096
  --> https://bugs.webkit.org/attachment.cgi?id=444096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444096&action=review

r=me

> Source/WebCore/inspector/WorkerInspectorController.cpp:140
> +#if ENABLE(SERVICE_WORKER)

Style: I'd add a newline after this

> Source/WebCore/inspector/WorkerInspectorController.cpp:160
> +#endif

Style: i'd add a newline before this and `// ENABLE(SERVICE_WORKER)`