[webkit-reviews] review granted: [Bug 233080] [webkitpy] Symlink daemons into simulator runtime root : [Attachment 444125] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 12 17:06:33 PST 2021
Brady Eidson <beidson at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 233080: [webkitpy] Symlink daemons into simulator runtime root
https://bugs.webkit.org/show_bug.cgi?id=233080
Attachment 444125: Patch
https://bugs.webkit.org/attachment.cgi?id=444125&action=review
--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 444125
--> https://bugs.webkit.org/attachment.cgi?id=444125
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=444125&action=review
> Tools/Scripts/webkitpy/api_tests/manager.py:156
> + # Daemons can't be called from outside the runtime root
I would phrase a bit differently, like:
"A Daemons executable path must be located within the runtime root"
More information about the webkit-reviews
mailing list