[webkit-reviews] review granted: [Bug 233001] WebKit is unable to recover if a WebProcess gets terminated while it is launching : [Attachment 444028] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 233001: WebKit is unable to recover if a WebProcess gets terminated while
it is launching
https://bugs.webkit.org/show_bug.cgi?id=233001

Attachment 444028: Patch

https://bugs.webkit.org/attachment.cgi?id=444028&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 444028
  --> https://bugs.webkit.org/attachment.cgi?id=444028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444028&action=review

r=me

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:325
> +	   terminateXPCConnection();

It's a little surprising that this is only an issue on macOS; do we not have a
similar issue with our termination logic on iOS?