[webkit-reviews] review granted: [Bug 232837] nullptr deref in CompositeEditCommand::insertNodeAt : [Attachment 443971] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 17:30:51 PST 2021

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 232837: nullptr deref in CompositeEditCommand::insertNodeAt

Attachment 443971: Patch


--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 443971
  --> https://bugs.webkit.org/attachment.cgi?id=443971

This patch is OK, but I think it could be made a little better by making the
test not depend on a "call stack size exceeded" exception and by doing the
orphan check earlier.

But neither of those seems a reason to not land it ... just that each of those
things would be a significant improvement.

More information about the webkit-reviews mailing list