[webkit-reviews] review denied: [Bug 232977] _WKWebAuthenticationPanel should expose a way to encode CTAP commands : [Attachment 444012] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Garrett Davidson
<garrett_davidson at apple.com>'s request for review:
Bug 232977: _WKWebAuthenticationPanel should expose a way to encode CTAP
commands
https://bugs.webkit.org/show_bug.cgi?id=232977

Attachment 444012: Patch

https://bugs.webkit.org/attachment.cgi?id=444012&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 444012
  --> https://bugs.webkit.org/attachment.cgi?id=444012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444012&action=review

r- to add ASSERT_NOT_REACHED() and since it looks like tv/watch builds need to
be fixed.

Otherwise looks good, but I'm not a domain expert.  :)

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:206
> +

Should have an `ASSERT_NOT_REACHED();` statement here before the `return`
statement for Debug builds.