[webkit-reviews] review requested: [Bug 233011] [WebAuthn] Stop serializing BufferSource and Vector<uint8_t> duplicates of identifiers : [Attachment 444005] Patch

[bugzilla-daemon at webkit.org]

j_pascoe at apple.com <j_pascoe at apple.com> has asked  for review:
Bug 233011: [WebAuthn] Stop serializing BufferSource and Vector<uint8_t>
duplicates of identifiers
https://bugs.webkit.org/show_bug.cgi?id=233011

Attachment 444005: Patch

https://bugs.webkit.org/attachment.cgi?id=444005&action=review




--- Comment #4 from j_pascoe at apple.com <j_pascoe at apple.com> ---
Comment on attachment 444005
  --> https://bugs.webkit.org/attachment.cgi?id=444005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444005&action=review

> Source/WebCore/Modules/webauthn/fido/U2fCommandConstructor.cpp:86
> +    // FIXME: Can we avoid this copy?

Can't find anywhere else that does no copy BufferSource->Vector<uint8_t>. Can't
find anywhere that uses this specific signature outside WebKit in clownfish, so
we may be safe removing the usages of it in U2fCommandConstructorTest and just
use the BufferSource version.