[webkit-reviews] review granted: [Bug 231600] REGRESSION: (r283871) [ macOS wk2 Release ] 2 css/cssom-view/scroll-behavior-main-frame tests are failing : [Attachment 443911] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 231600: REGRESSION: (r283871) [ macOS wk2 Release ] 2
css/cssom-view/scroll-behavior-main-frame tests are failing
https://bugs.webkit.org/show_bug.cgi?id=231600

Attachment 443911: Patch

https://bugs.webkit.org/attachment.cgi?id=443911&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443911
  --> https://bugs.webkit.org/attachment.cgi?id=443911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443911&action=review

> Source/WebCore/ChangeLog:10
> +	   request has come in (first animation still in
m_nodesWithPendingScrollAnimations). For the

"come in" could be more specific. Maybe "committed to the scrolling tree" or
"received by the scrolling thread", whichever it is.

> Source/WebCore/page/scrolling/ThreadedScrollingTree.h:67
> +    void removePendingScrollAnimationForNode(ScrollingNodeID nodeID)
WTF_REQUIRES_LOCK(m_treeLock) override {
m_nodesWithPendingScrollAnimations.remove(nodeID); }

Since this is virtual, I would move the implementation to the .cpp file.

I think it can be 'final' instead of 'override'.