[webkit-reviews] review granted: [Bug 233001] WebKit is unable to recover if a WebProcess gets terminated while it is launching : [Attachment 443960] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 233001: WebKit is unable to recover if a WebProcess gets terminated while
it is launching
https://bugs.webkit.org/show_bug.cgi?id=233001

Attachment 443960: Patch

https://bugs.webkit.org/attachment.cgi?id=443960&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 443960
  --> https://bugs.webkit.org/attachment.cgi?id=443960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443960&action=review

r=me

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:326
> +	   didFinishLaunchingProcess(0, IPC::Connection::Identifier());

It seems like it might be clearer if there was a method "didFailToLaunch" or
something that could call "didFinishLaunchingProcess" with the right arguments,
but also log something helpful to the console.