[webkit-reviews] review granted: [Bug 232974] Move image overlay code out of HTMLElement and into a separate helper file : [Attachment 443958] Fix Windows build

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 232974: Move image overlay code out of HTMLElement and into a separate
helper file
https://bugs.webkit.org/show_bug.cgi?id=232974

Attachment 443958: Fix Windows build

https://bugs.webkit.org/attachment.cgi?id=443958&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 443958
  --> https://bugs.webkit.org/attachment.cgi?id=443958
Fix Windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=443958&action=review

> Source/WebCore/ChangeLog:10
> +	   Move code for updating, querying, and removing image overlays out of
HTMLElement.cpp and HTMLElement.h and into
> +	   separate helper files instead (ImageOverlay.h and ImageOverlay.cpp).
Future patches in this area will extend the
> +	   functionality of these overlays, so this will help avoid code bloat
inside HTMLElement when doing so.

Nice!

> Source/WebCore/dom/ImageOverlay.cpp:168
> +void updateWithTextRecognitionResult(HTMLElement& element, const
TextRecognitionResult& result, CacheTextRecognitionResults
cacheTextRecognitionResults)

Would be nice to chop up this mega-function into smaller pieces at some point.