[webkit-reviews] review granted: [Bug 232848] Factor platform specific code out of HTMLModelElement : [Attachment 443849] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 232848: Factor platform specific code out of HTMLModelElement
https://bugs.webkit.org/show_bug.cgi?id=232848

Attachment 443849: Patch

https://bugs.webkit.org/attachment.cgi?id=443849&action=review




--- Comment #11 from Dean Jackson <dino at apple.com> ---
Comment on attachment 443849
  --> https://bugs.webkit.org/attachment.cgi?id=443849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443849&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:225
> +    // FIXME: For the early returns here, we should probably inform the page
that that things have

Typo: that that

> Source/WebKit/ChangeLog:9
> +	   Move implementation details of the macOS AVKit <model>
implementation
> +	   into an AVKit model player implementation.

ARKit, not AVKit.

> Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayer.mm:98
> +    auto fileName =
FileSystem::encodeForFileName(createCanonicalUUIDString()) + ".usdz";

Maybe use preferredExtensionForMIMEType? but i guess either way you're
hardcoding USD.