[webkit-reviews] review granted: [Bug 232645] REGRESSION(r283863): `<attachment>` with a long `action` do not render correctly : [Attachment 443860] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 232645: REGRESSION(r283863): `<attachment>` with a long `action` do not
render correctly
https://bugs.webkit.org/show_bug.cgi?id=232645

Attachment 443860: Patch

https://bugs.webkit.org/attachment.cgi?id=443860&action=review




--- Comment #12 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 443860
  --> https://bugs.webkit.org/attachment.cgi?id=443860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443860&action=review

> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:340
> +    // positions by reversing the operations applied to the original
advances.

Nit: I'd somehow work in the word "inverse" rather than "reverse".

> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:344
> +	   // FIXME: <https://webkit.org/b/232917> (`DrawGlyphsRecorder` should
be able to record+replay vertical text)

��

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:121
> +static void fillVectorWithHorizontalGlyphPositions(Vector<CGPoint, 256>&
positions, CGContextRef context, const CGSize* advances, unsigned count, const
FloatPoint& point)

heh cool