[webkit-reviews] review granted: [Bug 232737] Add basic support for launching CaptivePortalMode WebProcesses : [Attachment 443646] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 232737: Add basic support for launching CaptivePortalMode WebProcesses
https://bugs.webkit.org/show_bug.cgi?id=232737

Attachment 443646: Patch

https://bugs.webkit.org/attachment.cgi?id=443646&action=review




--- Comment #27 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 443646
  --> https://bugs.webkit.org/attachment.cgi?id=443646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443646&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h:74
> +/*! @abstract A boolean indicating whether captive portal mode is enabled.

nit: Captive Portal ?

> Tools/TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:14
> +	   <true/>

Nit: Weird whitespace.