[webkit-reviews] review granted: [Bug 232905] Upstream: Fix occlusion query buffer synchronization in angle end2end tests : [Attachment 443727] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 232905: Upstream: Fix occlusion query buffer synchronization in angle
end2end tests
https://bugs.webkit.org/show_bug.cgi?id=232905

Attachment 443727: Patch

https://bugs.webkit.org/attachment.cgi?id=443727&action=review




--- Comment #3 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 443727
  --> https://bugs.webkit.org/attachment.cgi?id=443727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443727&action=review

looks good with the nits fixed

> Source/ThirdParty/ANGLE/ChangeLog:6
> +	Ensure that GPU synchronization is flushed before

ChangeLog needs a certain format, these need the tabs

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h:91
> +	    // encoded on the GPU, and a map operation must wait

comment lines don't align