[webkit-reviews] review granted: [Bug 232909] [iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:] : [Attachment 443770] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 232909: [iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
https://bugs.webkit.org/show_bug.cgi?id=232909

Attachment 443770: Patch

https://bugs.webkit.org/attachment.cgi?id=443770&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 443770
  --> https://bugs.webkit.org/attachment.cgi?id=443770
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443770&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:195
> +	   if
(proxy.gpuConnectionToWebProcess().presentingApplicationAuditToken())
> +	      
presentingProcesses.append(*proxy.gpuConnectionToWebProcess().presentingApplica
tionAuditToken());

Nit: it would be more efficient, in a Debug build at least, to put the token
into a local variable