[webkit-reviews] review granted: [Bug 232855] BroadcastChannel is still disabled in service workers : [Attachment 443716] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 232855: BroadcastChannel is still disabled in service workers
https://bugs.webkit.org/show_bug.cgi?id=232855

Attachment 443716: Patch

https://bugs.webkit.org/attachment.cgi?id=443716&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 443716
  --> https://bugs.webkit.org/attachment.cgi?id=443716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443716&action=review

> Source/WTF/ChangeLog:9
> +	   Turn on BroadcastChannel experimental feature in WebCore since this
is the value that Service Workers
> +	   end up using. We only need to disable it in WebKitLegacy.

It worries me a little to learn that Service Workers end up using a different
set of features than the ones set by WebKit API. Makes me worry about our
preferences machinery; is that really OK?