[webkit-reviews] review granted: [Bug 232686] Compiler should be able to check localized format strings for consistency : [Attachment 443511] Patch v8

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 232686: Compiler should be able to check localized format strings for
consistency
https://bugs.webkit.org/show_bug.cgi?id=232686

Attachment 443511: Patch v8

https://bugs.webkit.org/attachment.cgi?id=443511&action=review




--- Comment #34 from Darin Adler <darin at apple.com> ---
Comment on attachment 443511
  --> https://bugs.webkit.org/attachment.cgi?id=443511
Patch v8

Seems fine as long as we get an error if I pass a CFStringRef that does not
come from WEB_UI_FORMAT_CFSTRING to formatLocalizedString.

I’m also not sure why we name the macro WEB_UI_FORMAT_CFSTRING instead of just
WEB_USE_FORMAT_STRING. It’s not like any one port supports both.