[webkit-reviews] review granted: [Bug 232863] Fix wrong frame count of CARingBuffer in SpeechRecognitionRemoteRealtimeMediaSource : [Attachment 443650] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 232863: Fix wrong frame count of CARingBuffer in
SpeechRecognitionRemoteRealtimeMediaSource
https://bugs.webkit.org/show_bug.cgi?id=232863

Attachment 443650: Patch

https://bugs.webkit.org/attachment.cgi?id=443650&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 443650
  --> https://bugs.webkit.org/attachment.cgi?id=443650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443650&action=review

> Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86
> +    m_description = description;

Do we need to set m_description here again, since we already set it when
allocating m_ringBuffer?
It seems we should set m_description once and I would tend to do it in
audioSamplesAvailable.