[webkit-reviews] review granted: [Bug 232830] Re-use isCSSWideKeyword in CSSVariableParser.cpp & CSSPropertyParser.cpp : [Attachment 443584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 23:46:53 PST 2021


Antti Koivisto <koivisto at iki.fi> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 232830: Re-use isCSSWideKeyword in CSSVariableParser.cpp &
CSSPropertyParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=232830

Attachment 443584: Patch

https://bugs.webkit.org/attachment.cgi?id=443584&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 443584
  --> https://bugs.webkit.org/attachment.cgi?id=443584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443584&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:4568
> -	   CSSValueID id = m_range.peek().id();
> -	   if (id == CSSValueInherit || id == CSSValueInitial || id ==
CSSValueRevert)
> +	   if (isCSSWideKeyword(m_range.peek().id()))

Can we make a test for this?


More information about the webkit-reviews mailing list