[webkit-reviews] review granted: [Bug 232818] Make it possible to toggle several experimental media features when GPU Process is enabled : [Attachment 443572] For EWS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 15:17:17 PST 2021


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 232818: Make it possible to toggle several experimental media features when
GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=232818

Attachment 443572: For EWS

https://bugs.webkit.org/attachment.cgi?id=443572&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 443572
  --> https://bugs.webkit.org/attachment.cgi?id=443572
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=443572&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:590
> +    for (auto page : webProcess.pages()) {

While this is still a wild layering problem, it's strictly better than using
the WebPageGroup prefs.

I think you removed a bit too much of the "omg here be dragons" comment though;
the caveats in your changelog should be mentioned here too.

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:-670
> -    setScreenProperties(WebCore::collectScreenProperties());

as you pointed out yourself, you lost canSendMessage here.


More information about the webkit-reviews mailing list