[webkit-reviews] review granted: [Bug 232798] [WebXR] three.js demos don't work : [Attachment 443588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 12:56:58 PST 2021


Myles C. Maxfield <mmaxfield at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 232798: [WebXR] three.js demos don't work
https://bugs.webkit.org/show_bug.cgi?id=232798

Attachment 443588: Patch

https://bugs.webkit.org/attachment.cgi?id=443588&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 443588
  --> https://bugs.webkit.org/attachment.cgi?id=443588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443588&action=review

> Source/WebCore/ChangeLog:26
> +

What’s the long term strategy to test this stuff? I’m willing to review this
one patch without a test because AIUI there is no testing infrastructure yet,
but there should at least be a plan about how we’re going to add tests on the
future.


More information about the webkit-reviews mailing list