[webkit-reviews] review granted: [Bug 232433] Web Inspector: Add script to update CSSDocumentation.js : [Attachment 443550] [fast-cq] Patch 2.2

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Razvan Caliman
<rcaliman at apple.com>'s request for review:
Bug 232433: Web Inspector: Add script to update CSSDocumentation.js
https://bugs.webkit.org/show_bug.cgi?id=232433

Attachment 443550: [fast-cq] Patch 2.2

https://bugs.webkit.org/attachment.cgi?id=443550&action=review




--- Comment #16 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 443550
  --> https://bugs.webkit.org/attachment.cgi?id=443550
[fast-cq] Patch 2.2

View in context: https://bugs.webkit.org/attachment.cgi?id=443550&action=review

r=me

Have we thought at all about what process we want to have in place for making
sure this gets regularly updated?  Perhaps we can file bugs alongside the
"create new protocol version" bugs that we already have to make sure that we at
least update this script every time we save a protocol version too?

> Source/WebInspectorUI/Scripts/update-inspector-css-documentation:68
> +    if (url and not url.startswith("https://developer.mozilla.org")):

What about if there's a MDN link as the second reference?  Maybe we should
iterate over `references` until we find a MDN link and then `break` after the
first one?