[webkit-reviews] review granted: [Bug 232788] [Live Text] Add a helper method to remove recognized text from an image element : [Attachment 443490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 10:34:24 PST 2021


Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 232788: [Live Text] Add a helper method to remove recognized text from an
image element
https://bugs.webkit.org/show_bug.cgi?id=232788

Attachment 443490: Patch

https://bugs.webkit.org/attachment.cgi?id=443490&action=review




--- Comment #2 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 443490
  --> https://bugs.webkit.org/attachment.cgi?id=443490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443490&action=review

> Source/WebCore/html/HTMLElement.cpp:1341
> +	   RefPtr<HTMLDivElement> containerToRemove;

Is this variable necessary? Why not just remove the container in the loop?


More information about the webkit-reviews mailing list