[webkit-reviews] review granted: [Bug 232805] Fix the CGEvent types used for wheel event generation from streams : [Attachment 443524] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 08:36:42 PST 2021


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 232805: Fix the CGEvent types used for wheel event generation from streams
https://bugs.webkit.org/show_bug.cgi?id=232805

Attachment 443524: Patch

https://bugs.webkit.org/attachment.cgi?id=443524&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 443524
  --> https://bugs.webkit.org/attachment.cgi?id=443524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443524&action=review

> Tools/ChangeLog:10
> +	   The set of enum values for wheel event types are confusing, and I
used the wrong ones in
> +	   r285390, so fix that. Values are all the same other than
kCGMomentumScrollPhaseEnd which is
> +	   now correct.

Is the end phase being different detectable?


More information about the webkit-reviews mailing list